Update lookup model in console #15472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavbhole
force-pushed
the
updateLookupsModel
branch
from
f928f70
to
59c1821
Compare
vogievetsky
reviewed
Dec 2, 2023
30 is placeholder value which is recommended to set to starts with. May be placeholder string needs to be amended to depict it correctly. Let me know if you have suggestions., |
pranavbhole
force-pushed
the
updateLookupsModel
branch
from
c74c7d3
to
c6406c2
Compare
vogievetsky
reviewed
Dec 4, 2023
| @@ -464,30 +464,30 @@ export const LOOKUP_FIELDS: Field<LookupSpec>[] = [ | |||
| { | |||
| name: 'extractionNamespace.jitterSeconds', | |||
| type: 'number', | |||
| placeholder: '30 (optional), default is 0', | |||
| placeholder: '30 (optional) ', | |||
There was a problem hiding this comment.
instead of setting the placeholder this you could just add defaultValue: 30 this basically sets the placeholder to 30. The (optional) label is not needed because visually when you open the form and there is a default value filled in as the placeholder it visually conveys "optional". The placeholder is really there for when you need to override the default behavior that I don't think you need to do here.
|
thank you for address in the various feedbacks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding optional jitterSeconds, loadTimeoutSeconds,maxHeapPercentage to jdbc lookup add/edit forms. We had added first 2 params recently https://github.com/apache/druid/blob/master/docs/development/extensions-core/lookups-cached-global.md#jdbc-lookup specifically for jdbc.
This PR has: